Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Adding the depends annotation to Integration Tests #4807

Merged
merged 4 commits into from
Jun 27, 2019

Conversation

eduard13
Copy link
Contributor

@eduard13 eduard13 commented Jun 23, 2019

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@rogyar rogyar self-assigned this Jun 23, 2019
@rogyar
Copy link
Contributor

rogyar commented Jun 24, 2019

Hi @eduard13. That's a great topic. Thank you for the collaboration

@rogyar rogyar added 2.1.x 2.2.x 2.3.x Magento 2.3 related changes New Topic A major update published as an entirely new document labels Jun 24, 2019
@erikmarr erikmarr self-requested a review June 26, 2019 14:08
Copy link
Contributor

@erikmarr erikmarr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks really good! Just some minor feedback.

@eduard13
Copy link
Contributor Author

Hi @erikmarr, thank you for your suggestions, they were applied.

@erikmarr
Copy link
Contributor

running tests

@erikmarr erikmarr merged commit ef93d28 into magento:master Jun 27, 2019
@ghost
Copy link

ghost commented Jun 27, 2019

Hi @eduard13, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@erikmarr
Copy link
Contributor

Thanks @eduard13!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.1.x 2.2.x 2.3.x Magento 2.3 related changes New Topic A major update published as an entirely new document Partner: Atwix partners-contribution PR created by Magento partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants