Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Cloud 2002.0.20 release #4839

Merged
merged 37 commits into from
Jun 27, 2019
Merged

Cloud 2002.0.20 release #4839

merged 37 commits into from
Jun 27, 2019

Conversation

hguthrie
Copy link
Contributor

@hguthrie hguthrie commented Jun 26, 2019

This contains the updates for the Cloud 2002.0.20 release.
https://magento2.atlassian.net/browse/MAGECLOUD-3731

  • Add changes from MAGECLOUD-3357
  • final dev review
  • whatsnew updated with links
  • editor review
  • YAML check
  • link check

whatsnew
Updated the Cloud Release notes for ece-tools version 2002.0.20.

meker12 and others added 20 commits May 13, 2019 11:19
- Added the FORCE_UPDATE_URLS deploy variable to update Magento base URLs when deploying Magento Commerce Cloud projects to production and staging environments.
- Updated the release notes for 2002.0.19
* MAGECLOUD-2973 db table prefixes

* updates from technical review
* MAGECLOUD-3258 warm cache with multiple pages

* Improved example using regexp
* MAGECLOUD-3258: warm cache with multiple pages

* MAGECLOUD-3258: warm cache with multiple pages
* Add link to variable for convenience

* MAGECLOUD-3813 ece-tools reference

* add repo link

* Update ece-tools-reference.md

* oops, forgot to update later version

* Update from feedback
* Added TTFB_TESTED_PAGE env variable and associated release note
* MAGECLOUD-3684 add functional testing

* add to all versions

* Update examples and leftover questions

* slight fix

* fix bad formatting in docker arch

* forgot about version 2.2

* Apply suggestions from code review

Co-Authored-By: Margaret Eker <[email protected]>

* Update from feedback
@hguthrie hguthrie added 2.1.x Major Update Significant original updates to existing content 2.2.x Internal Dev Differentiates work between community and Magento staff 2.3.x Magento 2.3 related changes labels Jun 26, 2019
@hguthrie hguthrie self-assigned this Jun 26, 2019
@hguthrie
Copy link
Contributor Author

So far link check runs fine, but staging build fails because of the magento-cloud.json file.

@hguthrie hguthrie marked this pull request as ready for review June 27, 2019 12:22
@jeff-matthews
Copy link
Contributor

Looks good! I think that the new magento-cloud.json file needs to be converted to YAML to build properly though.

@dshevtsov
Copy link
Collaborator

dshevtsov commented Jun 27, 2019

Yes, the Ruby Docker container fails in some reason.
To generate the file in YAML, you can use the following one-liner in Bash with Ruby:

$ bin/magento list --format=json | ruby -ryaml -e 'print YAML.load(STDIN).to_yaml' >  [path to devdocs]/_data/codebase/v2_[your version]/cloud/magento-cloud.yml

@hguthrie
Copy link
Contributor Author

Copy link
Contributor

@meker12 meker12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added a few suggestions.

- **Version**—Magento 2.1.4 and later

Customize the list of pages used to preload the cache in the `post_deploy` stage. You must configure the post-deploy hook. See the [hooks section][] of the `.magento.app.yaml` file.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like link target is missing on the [hooks section].


The `codeception.dist.yml` file in the `{{site.data.var.ct}}` root directory contains the global testing configuration. See the [`{{site.data.var.ct}}` repository](https://github.com/magento/ece-tools/blob/develop/codeception.dist.yml).

By default, functional tests produce a short output. You can receive a more detailed output by editing the `codeception.dist.yml` file to set the `printOutput:` property to `true`.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
By default, functional tests produce a short output. You can receive a more detailed output by editing the `codeception.dist.yml` file to set the `printOutput:` property to `true`.
By default, functional tests produce a short output. You can get more detailed output by editing the `codeception.dist.yml` file to set the `printOutput:` property to `true`.

@hguthrie
Copy link
Contributor Author

running tests

@hguthrie hguthrie merged commit e7ad758 into master Jun 27, 2019
@ghost
Copy link

ghost commented Jun 27, 2019

Hi @hguthrie, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

@hguthrie hguthrie deleted the Cloud-2002.0.20 branch June 28, 2019 14:52
@meker12 meker12 mentioned this pull request Jul 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.1.x 2.2.x 2.3.x Magento 2.3 related changes Internal Dev Differentiates work between community and Magento staff Major Update Significant original updates to existing content
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants