This repository was archived by the owner on Nov 19, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* MAGECLOUD-3871: Write cloud.log in debug level to file * Update guides/v2.2/cloud/env/variables-global.md Co-Authored-By: Margaret Eker <[email protected]>
After implementation MAGECLOUD-4242 we need to change the domain name. Should be merged after release ece-tools 2002.1.0 and magento-cloud-docker 1.0
- Replace v2.3 release notes with symlink - Add section for 2002.0.22 release notes - Remove obsolete version information from the Cloud TOC file
…dows (#5860) * MAGECLOUD-4099: Check how Mutagen (https://mutagen.io) works with Windows * MAGECLOUD-4099: Check how Mutagen (https://mutagen.io) works with Windows * Update guides/v2.2/cloud/docker/docker-config.md Co-Authored-By: Margaret Eker <[email protected]> * MAGECLOUD-4099: Check how Mutagen (https://mutagen.io) works with Windows
- Replace v2.3 release notes with symlink - Add section for 2002.0.22 release notes - Remove obsolete version information from the Cloud TOC file
- Fixed merge conflicts - Moved release notes to H1 in navigation
* Added information on custom docker configurations * Added page link * Fix the changes to config topic The config topic changed a lot from the original, so had to fix the merge conflict overwrite. And I edited the new message. * Update docker-quick-reference.md
* Added docs for new `native` option for file synchronization in developer mode * Added release note.
hguthrie
reviewed
Jan 31, 2020
src/cloud/docker/docker-extend.md
Outdated
|
||
```yaml | ||
version: '2.1' | ||
services: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think services should be indented. It is isn't in my YAML file, but do check just in case.
hguthrie
previously approved these changes
Jan 31, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is a link that needs fixing in docker-config file. And there is a YAML file that needs indentation fix. Otherwise, it can probably go on to a release branch.
Co-Authored-By: hguthrie <[email protected]>
Co-Authored-By: hguthrie <[email protected]>
* Updates based on review feedback
hguthrie
reviewed
Feb 3, 2020
Co-Authored-By: hguthrie <[email protected]>
Hi @meker12, thank you for your contribution! |
meker12
added a commit
that referenced
this pull request
Feb 5, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this pull request
Draft pull request for Cloud-Docker-1.0.0 release doc review