Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Added Slave Database Connection Information #7924

Merged

Conversation

BarnyShergold
Copy link
Contributor

Purpose of this pull request

This pull request (PR) fixes #6067

Affected DevDocs pages

https://devdocs.magento.com/cloud/project/services-mysql.html

@devops-devdocs
Copy link
Collaborator

An admin must run tests on this PR before it can be merged.

@BarnyShergold
Copy link
Contributor Author

@meker12 & @hguthrie - I thought I'd get this issue underway and start with some basic information. Where shall we go from here?

@rogyar rogyar self-assigned this Sep 24, 2020
@rogyar rogyar added 2.3.x Magento 2.3 related changes 2.4.x Magento 2.4.x related changes labels Sep 24, 2020
Copy link
Contributor

@rogyar rogyar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In the future, it would be great to provide some information on how the fact of different ports affects the configuration (configuration examples)

@BarnyShergold
Copy link
Contributor Author

In the future, it would be great to provide some information on how the fact of different ports affects the configuration (configuration examples)

@rogyar - I agree but where can we get the definitive port information from? (BTW I wasn't expecting this PR to be reviewed yet, was waiting to discuss and expand with @hguthrie & @meker12 )

@BarnyShergold BarnyShergold changed the title Added Slave Database Connection Information [WIP] Added Slave Database Connection Information Sep 24, 2020
@dobooth
Copy link
Contributor

dobooth commented Sep 24, 2020

Slave isn't going to work as a term. Let's use 'secondary'.

@meker12
Copy link
Contributor

meker12 commented Sep 24, 2020

Slave isn't going to work as a term. Let's use 'secondary'.
We can use that in the text, but the Magento code base still uses master/slave for databases.

@meker12 meker12 self-requested a review September 24, 2020 19:56
@meker12
Copy link
Contributor

meker12 commented Sep 24, 2020

running tests

@meker12 meker12 merged commit 6e26c9e into magento:master Sep 24, 2020
@ghost
Copy link

ghost commented Sep 24, 2020

Hi @BarnyShergold, thank you for your contribution!
Please, complete Contribution Survey, it will take less than a minute.
Your feedback will help us to improve contribution process.

meker12 added a commit that referenced this pull request Sep 29, 2020
* Update prereq-overview.md

* Update prereq-overview.md

Reword following review

* Update prereq-overview.md

Clarify MySQL version for 2.4

* Update prereq-overview.md

Version fix

* Update src/guides/v2.3/install-gde/prereq/prereq-overview.md

Suggested change

Co-authored-by: Barny Shergold <[email protected]>

* Update src/guides/v2.4/install-gde/prereq/prereq-overview.md

Suggested change

Co-authored-by: Barny Shergold <[email protected]>

* Update contributing.md

* Static fixes

* Fixed MD formatting

* Update ui-columnscontrols.md

<setting> is Invalid XML tag, correct tag is <settings>

* Fix return for extractAdjustment

* Update src/guides/v2.3/extension-dev-guide/price-adjustments.md

Co-authored-by: Yaroslav Rogoza <[email protected]>

* Capitalize MySQL

* Capitalize MySQL

* Added Sequence Load information

* Update message-queues-stores.md

Remote Warning for required patch

* Fix missing "\" in new implementation example

* Fix broken link (#7915)

* formatting change

* Editorial/elastic variable (#7919)

* Update Additional search configuration section

* Grammar update

* Update src/cloud/project/services-elastic.md

Co-authored-by: Barny Shergold <[email protected]>
Co-authored-by: Donald Booth <[email protected]>
Co-authored-by: Margaret Eker <[email protected]>

* Grammar and formatting

* I linted myself.

* typo

* Usage examples are added

* Markdown fixes

* MCLOUD-6977: Update documentation about routes (#7912) (#7927)

* MCLOUD-6977: Update documentation about routes

* Update src/cloud/project/routes.md

Co-authored-by: Margaret Eker <[email protected]>
Co-authored-by: Barny Shergold <[email protected]>
Co-authored-by: Nadiya Syvokonenko <[email protected]>

* [WIP] Added Slave Database Connection Information (#7924)

* Added Slave Database Connection Information
* Update src/cloud/project/services-mysql.md

* Update services-mysql.md

Co-authored-by: Barny Shergold <[email protected]>
Co-authored-by: Margaret Eker <[email protected]>

* (maintenance) Add init to build:stage (#7941)

* Add init to build:stage

Required for new CI/CD staging

* Fix syntax

* Improving the create a new page layout topic

* Update project-routes-more-redir.md

Removed extra curly brace

* Grammar and formatting

* Update GraphQL index page

Co-authored-by: DominicWatts <[email protected]>
Co-authored-by: Barny Shergold <[email protected]>
Co-authored-by: Stanislav Idolov <[email protected]>
Co-authored-by: Jeff Matthews <[email protected]>
Co-authored-by: Keyur Shah <[email protected]>
Co-authored-by: Iftakharul Alam <[email protected]>
Co-authored-by: Yaroslav Rogoza <[email protected]>
Co-authored-by: Donald Booth <[email protected]>
Co-authored-by: Barny Shergold <[email protected]>
Co-authored-by: Lyzun Oleksandr <[email protected]>
Co-authored-by: Brett P <[email protected]>
Co-authored-by: Margaret Eker <[email protected]>
Co-authored-by: hguthrie <[email protected]>
Co-authored-by: Kevin Harper <[email protected]>
Co-authored-by: Nadiya Syvokonenko <[email protected]>
Co-authored-by: Dmitry Shevtsov <[email protected]>
Co-authored-by: eduard13 <[email protected]>
Co-authored-by: Kevin Harper <[email protected]>
@meker12 meker12 changed the title [WIP] Added Slave Database Connection Information Added Slave Database Connection Information Oct 2, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
2.3.x Magento 2.3 related changes 2.4.x Magento 2.4.x related changes Partner: Vaimo partners-contribution PR created by Magento partner
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feedback on ece-tools package topic
6 participants