Thanks to visit codestin.com
Credit goes to github.com

Skip to content
This repository was archived by the owner on Nov 19, 2024. It is now read-only.

Added definition for <block>, <arguments> and <argument> #898

Closed
wants to merge 1 commit into from

Conversation

riconeitzel
Copy link
Contributor

No description provided.

@ghost ghost assigned ghost and almarchenko Nov 12, 2016
@ghost ghost removed their assignment Nov 26, 2016
@almarchenko
Copy link
Contributor

almarchenko commented Jan 6, 2017

@riconeitzel Thank you for your input!
Looks like this table only contains the instructions specific for page configuration files. All other instructions are described in the Layout instructions topic.
(see the text right before the table).
<block> and <argument> are described there, though <arguments> is not.
If you are willing, you can change the PR. But also we can close it, and I will add <arguments> in xml-instructions.md myself.
Please let me know what do you prefer! Thank you.

@almarchenko almarchenko added the Waiting for Response Waiting for response from internal/external parties label Jan 6, 2017
@riconeitzel
Copy link
Contributor Author

@almarchenko hi oleksandra, I'm currently slightly out of time. If you get it done in the next 2 weeks, feel free to close the PR and migrate it yourself. If not: Let it open and I'll check back in a week or two. Rico :-)

@almarchenko
Copy link
Contributor

almarchenko commented Jan 12, 2017

@riconeitzel
Thank you!
Actually, i've re-read my comment and found that I didn't use the correct formatting, so the names of the instructions were lost%)
It was
"and are described there, though is not."
instead of
" <block> and <argument> are described there, though <arguments> is not."
I wonder what did you think about this strange wording:))
Anyway, thank you for your reply, I will close this and add it quickly myself.

@almarchenko almarchenko added the Help Wanted Help wanted for issue/PR label Jan 12, 2017
magento-cicd2 pushed a commit that referenced this pull request Jun 2, 2017
@riconeitzel riconeitzel deleted the patch-2 branch September 3, 2018 13:42
@hguthrie hguthrie removed the Waiting for Response Waiting for response from internal/external parties label Feb 19, 2019
@hguthrie hguthrie removed the Waiting for Response Waiting for response from internal/external parties label Feb 19, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Help Wanted Help wanted for issue/PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants