Thanks to visit codestin.com
Credit goes to github.com

Skip to content

MAGECLOUD-5181: Disable cron container by default #144

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 5, 2020
Merged

MAGECLOUD-5181: Disable cron container by default #144

merged 3 commits into from
Feb 5, 2020

Conversation

shiftedreality
Copy link
Member

@shiftedreality shiftedreality commented Feb 5, 2020 •
edited
Loading

Description

Fixed Issues (if relevant)

  1. Disable cron container by default #139
  2. https://magento2.atlassian.net/browse/MAGECLOUD-5181

Manual testing scenarios

  1. Build with default params
  2. Verify there is no cron container
  3. Verify environment works as expected
  4. Build with --with-cron
  5. Verify there is a cron container
  6. Verify environment works as expected

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages

@shiftedreality shiftedreality added Progress: review PR/issue status Release: 1.0.0 Magento-Cloud-Docker Release labels Feb 5, 2020
bbatsche
bbatsche previously approved these changes Feb 5, 2020
View reviewed changes
@andriyShevtsov
Copy link
Contributor

QA approved

@shiftedreality shiftedreality merged commit e8c469b into 1.0 Feb 5, 2020
@shiftedreality shiftedreality deleted the MAGECLOUD-5181-2 branch February 5, 2020 19:18
@shiftedreality shiftedreality mentioned this pull request Feb 6, 2020
Merged
This was referenced Feb 11, 2020
Closed
Merged
magento-devops-reposync-svc pushed a commit that referenced this pull request Apr 1, 2025
@andriyShevtsov
Merge pull request #144 from magento-commerce/php-8-4-docker-images
f13c1f9 
Add docker files for PHP 8.4
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bbatsche bbatsche bbatsche approved these changes

@NadiyaS NadiyaS NadiyaS approved these changes

Assignees

@andriyShevtsov andriyShevtsov

Labels
Progress: accept PR/issue status Release: 1.0.0 Magento-Cloud-Docker Release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shiftedreality @andriyShevtsov @bbatsche @NadiyaS