Thanks to visit codestin.com
Credit goes to github.com

Skip to content

MQE-1673: command.php truncating values '0' #398

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 30, 2019
Merged

MQE-1673: command.php truncating values '0' #398

merged 3 commits into from
Jul 30, 2019

Conversation

KevinBKozan
Copy link
Contributor

@KevinBKozan KevinBKozan commented Jul 29, 2019 •
edited
Loading

Description

  • added strlen to prevent removal of "0"
  • added bugfix for argumentParts array not being used

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@KevinBKozan
MQE-1673: command.php truncating values '0'
004becc 
- added strlen to prevent removal of "0"
@coveralls
Copy link

coveralls commented Jul 29, 2019 •
edited
Loading

Coverage Status

Coverage remained the same at 54.524% when pulling 53eca7c on MQE-1673 into b6c1e8a on develop.

@KevinBKozan
MQE-1673: command.php truncating values '0'
7e8b0f4 
- added argument array to command array, additional bugfix.
@tomreece tomreece self-requested a review July 30, 2019 15:10
@KevinBKozan KevinBKozan merged commit fcb8999 into develop Jul 30, 2019
@KevinBKozan KevinBKozan deleted the MQE-1673 branch July 30, 2019 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomreece tomreece tomreece approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@KevinBKozan @coveralls @tomreece