MQE-498: Ability to pass simple values into an action group #41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Fixed check for isPersisted, added trim to variableName to be able to replace into 'string' parameters.
- Fixed case of sending in $data.key$ as simple data.
- verification test updates - Added simpleData array to actionGroupObject
- Added check for simpleArgument matching, and different resolution strategy for them. - Verification and Unit test updates with more usecases
- simpledata -> data enum. - no longer two different $argument arrays, only one but a new one with name=>type mapping.
- Refactor to use arguments as ArgumentObjects.
- PHPMD and CS fixes.
- CR Refactoring.
- removed secondary loop, only looping through arguments once now.
- More CR Fixes, removal of empty argument method.
- Removed types, now only string.
- type=string will now ALWAYS return literally what was put into it. No xml.data resolution. - type=entity will now ALWAYS try to resolve the data passed in.
- missed commented out lines.
- Verification Test Fixes.
magento-cicd2
pushed a commit
that referenced
this pull request
Mar 26, 2021
[2.x] MQE-2585: use --no-sandbox chrome options for functional suite.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
typetoactionGroup<argument>elements.entity, can be overriden withstringto treat input as a string literal.Fixed Issues (if relevant)
Contribution checklist