MQE-1633 + MQE-1514 #436
MQE-1633 + MQE-1514 #436
Conversation
… & Expected Results in Allure - Added Allure firing of attachment to steps
… & Expected Results in Allure - bugfix for variable name
- Added AllureHelper + Unit tests - Added attachment event to curlHandler classes
- Added contents of 1633, changed the calls to use Helper class instead
| * @param string $caption | ||
| * @return void | ||
| */ | ||
| public static function addAttachmentToLastStep($data, $caption) |
There was a problem hiding this comment.
Just curious about in general when to use this over the current step? I see you use this one in the curl handler, but I cant figure out why. Maybe add a bit to the phpdoc like:
This function should be used when ___blahblahblah___
There was a problem hiding this comment.
I'll add a comment to clear it up, the gist of it is that during a step (aka a function called in the test via $I->doathing()) you use current. If the framework is doign its own logic outisde a function like that, you can add artifact to the last step (which is usually a comment step)
|
I do not see the request/response data in the build: http://10.234.204.237:8080/job/Functional-Tests-CE/2021/allure/#suites/8187718e2fd144987673ef34ee62b41b/136f33b4de6d9efe/ Am I blind?
|
|
@tomreece I forgot to commit a file for unit tests, that will fix the errors. And let me retrigger/reset up branches for the build, I may have messed something up there. |
- Unit test fix
- Updated docblock
|
Looks good to me. |
…quence-remove-sq-file Removing module-sequence dependency from MFTF
Description
see/dontseeurl actions +CurlHandlerfor persistence actionsContribution checklist