Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Removed breaking "\r\n" instances from command. #441

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Sep 13, 2019
Merged

Removed breaking "\r\n" instances from command. #441

merged 4 commits into from
Sep 13, 2019

Conversation

dobooth
Copy link
Contributor

@dobooth dobooth commented Sep 3, 2019

Description

Cleans up a command that had errant "\r\n" that would break the command if copy/pasted.

Contribution checklist

  • Pull request has a meaningful description of its purpose
  • All commits are accompanied by meaningful commit messages
  • All new or changed code is covered with unit/verification tests (if applicable)
  • All automated tests passed successfully (all builds on Travis CI are green)
  • Changes to Framework doesn't have backward incompatible changes for tests or have related Pull Request with fixes to tests

@dobooth dobooth added the DOC label Sep 3, 2019
@dobooth dobooth changed the base branch from develop to master September 3, 2019 16:06
@dobooth dobooth requested a review from soumyau September 3, 2019 16:06
@dobooth dobooth self-assigned this Sep 3, 2019
@dobooth dobooth changed the base branch from master to develop September 3, 2019 16:07
@coveralls
Copy link

coveralls commented Sep 3, 2019 •
edited
Loading

Coverage Status

Coverage increased (+1.4%) to 53.592% when pulling 3e6f1e0 on dobooth-linebreaks into 0fe97bb on develop.

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.1%) to 52.111% when pulling 0a2eafa on dobooth-linebreaks into 0fe97bb on develop.

tomreece
tomreece suggested changes Sep 3, 2019
View reviewed changes
@KevinBKozan KevinBKozan merged commit 03c1f19 into develop Sep 13, 2019
@dobooth dobooth deleted the dobooth-linebreaks branch December 13, 2019 17:08
magento-devops-reposync-svc pushed a commit that referenced this pull request Feb 13, 2025
@KevinBKozan
Merge pull request #441 from magento-commerce/ACQE-7537-components-up…
bcd194e 
…grade

ACQE-7537 : MFTF Components upgrade
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tomreece tomreece tomreece approved these changes

@soumyau soumyau Awaiting requested review from soumyau

Assignees

@dobooth dobooth

Labels
DOC
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dobooth @coveralls @tomreece @KevinBKozan