-
Notifications
You must be signed in to change notification settings - Fork 132
[Pangolin] Deliver changes after MFTF training feedback #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ti-stores # Conflicts: # src/Magento/FunctionalTestingFramework/DataGenerator/Api/ApiExecutor.php # src/Magento/FunctionalTestingFramework/DataGenerator/Handlers/JsonDefinitionObjectHandler.php # src/Magento/FunctionalTestingFramework/DataGenerator/Objects/DataElement.php # src/Magento/FunctionalTestingFramework/DataGenerator/Util/JsonObjectExtractor.php # src/Magento/FunctionalTestingFramework/Util/TestGenerator.php
…develop' into MQE-326-multi-stores # Conflicts: # src/Magento/FunctionalTestingFramework/DataGenerator/Api/ApiExecutor.php # src/Magento/FunctionalTestingFramework/DataGenerator/Handlers/JsonDefinitionObjectHandler.php # src/Magento/FunctionalTestingFramework/DataGenerator/Objects/DataElement.php # src/Magento/FunctionalTestingFramework/DataGenerator/Util/JsonObjectExtractor.php # src/Magento/FunctionalTestingFramework/Util/TestGenerator.php
…meters - Added trim to parameter processing to prevent erroneous spaces.
…r Error - Added waitForLoadingMaskToDisappear to di.xml
…cution - change test schema for simpler persisted entity relationships - change data persistence handler to resolve entity relationships - change data schema to allow var declaration as a placehold for persisted data
…cution - remove old entity test schema declarations
…) is inside $$ signs - Updated Regex for persisted variable replacement.
…ates - Edited di.xml to use Module instead of Mask for Pages/Sections.
- Changed selector resolution to call uniquenessFunctionCall. Solves issue with safe backwards compatibility. - Generator was stripping ' from selector strings like: #'{{name}}', turning that into #{{name}} when resolved.
- di.xml update, turns out there's way more wrong here than just di.xml - Changed CAP to append actiongroup Mergekey to steps when processing ActionGroups, otherwise the CAP would find duplicate keys and overwrite them (since the ActionGroup steps technically had the same keys).
…ing-framework into sprint-develop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope
Stories
Related Pull Requests
https://github.com/magento/magento2ee/pull/739
https://github.com/magento/magento2ce/pull/1560
Created by : @tomreece
Internal PR: https://github.com/magento-pangolin/magento2-functional-testing-framework/pull/14