Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix WebView default properties to required #269

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 11, 2020
Merged

Fix WebView default properties to required #269

merged 1 commit into from
Mar 11, 2020

Conversation

panwrona
Copy link
Contributor

@panwrona panwrona commented Mar 10, 2020 •
edited
Loading

Thank you for your contribution to MagicScript Project.
Before submitting this PR, please make sure:

  • Your code builds clean without any errors or warnings
  • You are using approved terminology
  • You have added unit tests
  • You have updated documentation

Resolve #237

ghost
ghost approved these changes Mar 10, 2020
View reviewed changes
Copy link

@ghost ghost left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

@panwrona panwrona merged commit c396c06 into master Mar 11, 2020
@panwrona panwrona deleted the fix_webview_default_properties branch March 11, 2020 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@grzegorzdec grzegorzdec Awaiting requested review from grzegorzdec

@darek607 darek607 Awaiting requested review from darek607

@grozdanov grozdanov Awaiting requested review from grozdanov

@kpiascik kpiascik Awaiting requested review from kpiascik

@pleszkiewicz pleszkiewicz Awaiting requested review from pleszkiewicz

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Update [WebView] default properties
1 participant
@panwrona