Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Bugfix/#313 buggy cookie bar #343

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bugfix/#313 buggy cookie bar #343

wants to merge 2 commits into from

Conversation

pleszkiewicz
Copy link
Contributor

@pleszkiewicz pleszkiewicz commented Feb 4, 2021 •
edited
Loading

How to test these changes:

  1. clone the repo
  2. from the terminal go to the magic-script-components/website folder
  3. run yarn install
  4. run yarn start
  5. documentation website should open in your default web browser
  6. observe the cookie bar at the bottom of the page (the bar should be visible while you navigate through sub-pages and/or until you click Accept All Cookies button)

Closes #313
Closes #314

cookie_bars

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kpiascik kpiascik Awaiting requested review from kpiascik

@grozdanov grozdanov Awaiting requested review from grozdanov

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Getting Started subpage is blank when visited directly from address bar. The footer with cookies is not clickable on magicscript.org.
1 participant
@pleszkiewicz