feat: updated Scroll Based Velocity component to disable scroll prop for infinite text scrolling#896
Conversation
|
@Aniket-a14 is attempting to deploy a commit to the product-studio Team on Vercel. A member of the Team first needs to authorize it. |
|
@Yeom-JinHo hey! just like you mentioned I have updated the component to allow option to disable the scroll prop, can you review it once? |
There was a problem hiding this comment.
Pull request overview
This PR adds a scrollReactivity boolean prop to the ScrollVelocityRow component, which when set to false disables scroll-based speed modulation so the text scrolls at a constant base velocity regardless of the page scroll speed. The PR also incidentally includes an unrelated fix to the Pointer component that adds setIsActive(true) inside handleMouseMove.
Changes:
- Added
scrollReactivity?: booleanprop toScrollVelocityRowPropsandScrollVelocityRowImpl, defaulting totrue(backwards compatible) - Updated
useAnimationFramelogic to zero outvelocityFactorwhenscrollReactivity=false - Updated documentation table and pre-built JSON/text artifacts to reflect the new prop
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
apps/www/registry/magicui/scroll-based-velocity.tsx |
Core implementation of scrollReactivity prop |
apps/www/public/r/scroll-based-velocity.json |
Pre-built registry artifact updated to match source |
apps/www/public/r/pointer.json |
Registry artifact updated with unrelated Pointer fix (setIsActive(true) in handleMouseMove) |
apps/www/public/llms-full.txt |
LLM context file updated with both the scrollReactivity change and the unrelated Pointer fix |
apps/www/content/docs/components/scroll-based-velocity.mdx |
Documentation table updated to include scrollReactivity prop |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Yeom-JinHo
left a comment
There was a problem hiding this comment.
@Aniket-a14
Thank you for incorporating the feedback so quickly.
It looks like some unintended changes were automatically inserted by lefthook, so I’ve pushed a clean-up commit to main.
Once you rebase your branch, I’ll go ahead and merge it.
…for infinite text scrolling
|
@Yeom-JinHo I have rebased my branch, can you check it please? |
|
Thnaks @Aniket-a14 |
Updated the scroll based velocity componenet