Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Move to SI Units + Redefine magnetization and add codependency with polarization #712

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 154 commits into from
Jan 19, 2024
Merged

Move to SI Units + Redefine magnetization and add codependency with polarization #712

merged 154 commits into from
Jan 19, 2024

Conversation

OrtnerMichael
Copy link
Member

Related Issues

Notes

This PR includes two changes:

  • Changing all inputs and outputs to SI units!
  • Adding the polarization attribute to magnets which is co-dependent with the magnetization attribute

BREAKING CHANGES - this will be part of Magpylib v5

OrtnerMichael and others added 30 commits December 15, 2023 00:46
@OrtnerMichael
magnetization-polarization step 1
76ea747
@OrtnerMichael
untrack non-python __temp files
f80c813
@OrtnerMichael @Alexboiboi
next update
a43d3a6 
Co-authored-by: Alexandre Boisselet <[email protected]>
@OrtnerMichael
fix cuboid
f36f8ac
@OrtnerMichael
MU0
bffc185
@OrtnerMichael
fixing bh cuiboid again
ed8498d
@OrtnerMichael
cuboid fix again
1d9293d
@OrtnerMichael
another cube field fix
da9ec79
@OrtnerMichael
field_BH_cylinder fix
8d506de
@OrtnerMichael
fix field_BH_sphere
11cda87
@OrtnerMichael
Cylinder segment
0f02168
@OrtnerMichael
core tetrahedron and triangle
a9727b7
@OrtnerMichael
field_BH_triangularmesh fixed
3026be4
@Alexboiboi
typo
3ef0019
@OrtnerMichael
signular to plural
6bea7eb
@OrtnerMichael
current loop core
d3f1efb
@OrtnerMichael
field core polyline fix
9c0752b
@OrtnerMichael
minifix docstring
3717851
@OrtnerMichael
fixed dipole
38e9e81
@OrtnerMichael
core tests und 2 bugfixes
df84e7a
@OrtnerMichael
long solenoid test
d2ef80e
@OrtnerMichael
comments
b74e066
@OrtnerMichael
core physics tests
0e04020
@OrtnerMichael
complete core testing
6277043
@OrtnerMichael
fix core examples
07dced6
@Alexboiboi
fix Cuboid units
a9201e3
@Alexboiboi
fix Cylinder
05009cb
@Alexboiboi
fix CylinderSegment
f6497bc
@Alexboiboi
fix Sphere
e4f7304
@Alexboiboi
fix magnetization docstring
6d913db
@OrtnerMichael OrtnerMichael mentioned this pull request Jan 18, 2024
Closed
3 tasks
@OrtnerMichael OrtnerMichael mentioned this pull request Jan 19, 2024
Closed
@Alexboiboi Alexboiboi marked this pull request as ready for review January 19, 2024 09:35
Alexboiboi
Alexboiboi approved these changes Jan 19, 2024
View reviewed changes
Copy link
Member

@Alexboiboi Alexboiboi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine for now, docs will be updated later

@Alexboiboi Alexboiboi merged commit 24118c5 into main Jan 19, 2024
@Alexboiboi Alexboiboi deleted the magnetization_polarization branch January 19, 2024 12:14
@OrtnerMichael OrtnerMichael restored the magnetization_polarization branch January 19, 2024 12:20
@Alexboiboi Alexboiboi deleted the magnetization_polarization branch January 22, 2024 15:15
This was referenced Jan 22, 2024
Closed
Closed
Closed
Closed
This was referenced Mar 9, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Alexboiboi Alexboiboi Alexboiboi approved these changes

Assignees
No one assigned
Labels
breaking changes implementation introduces breaking changes deprecation docs graphics refactoring
Projects
None yet
Milestone
Version 5
Development

Successfully merging this pull request may close these issues.
2 participants
@OrtnerMichael @Alexboiboi