-
Notifications
You must be signed in to change notification settings - Fork 60
Adds core tests #860
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Adds core tests #860
Conversation
@Alexboiboi @OrtnerMichael |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #860 +/- ##
==========================================
- Coverage 99.77% 99.51% -0.26%
==========================================
Files 52 55 +3
Lines 5660 7477 +1817
==========================================
+ Hits 5647 7441 +1794
- Misses 13 36 +23 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
If I understand this correctly, you want have a subset of the tests here to test against different libs that support the array-api standard? |
Sort of, but it's a bit more complicated. The core tests are useful because those are the only parts I'm currently converting to the array API standard. Having the core tests here means that, when I convert to the array API standard, I can use the However that's not quite the whole story. The
|
Additionally, these are the tests for the exact functions I'm converting, whereas all the other tests so far(at least as far as I can tell) are further up in the chain of abstraction, so I would only be able to test them with numpy, unless I also converted more of the code. Having these tests lets me test against the minimal amount of code necessary to convert the lowest level to the array API standard |
Adds tests for the core functions.
I just evaluated the functions given as examples in the docstring, and use those for tests.
I will switch this to use array-api-strict instead of numpy for the array api, but I figured it's better to just have this in general, so I'm adding this as a separate PR