Add the eslint GitHub Action Workflow#20
Merged
Conversation
…use it to run eslint, adding proper configurations. Also set things up to run stylelint, though we don't use that currently in an Action Workflow
de60e53 to
f3b80c3
Compare
jeffpaul
approved these changes
May 31, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
This PR adds in a new GitHub Action Workflow to run
eslint. We install and use10up-toolkitto handle this.This Workflow is set to run anytime code is pushed to
developormain(and there are JS files) or when a PR is opened againstdevelop(and there are JS files).Solves one of the issues reported in #12 but there's remaining items, so this PR won't close out that Issue
How to test the Change
Ensure the eslint Workflow ran when JS files changed: https://github.com/mailchimp/wordpress/actions/runs/9312339155/job/25632980222?pr=20
Changelog Entry