Fix generation of content types #9
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is necessary to support middleware that performs compression of the response.
This has been setting the `Content-Type` header to an empty string, because the `mime.TypeByExtension` function expects a string with a leading dot.
This was referenced Sep 1, 2015
Member
|
👍 awesome, thanks @danielwhite |
ian-kent
added a commit
that referenced
this pull request
Oct 6, 2015
Fix generation of content types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently static content is being assigned a
Content-Typeheader of an empty string.The index works out of the box correctly, but will misbehave if other middleware is added to the request handler.