Conversation
WalkthroughA version bump from 2.2.0 to 2.3.0 across pyproject.toml and CHANGELOG.md. The changelog documents the addition of batch_send methods to SendingApi, GeneralApi, ContactExportsApi, and ContactEventsApi with corresponding models, tests, and examples. Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~3 minutes Poem
Pre-merge checks and finishing touches❌ Failed checks (2 warnings)
✅ Passed checks (1 passed)
✨ Finishing touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
CHANGELOG.md (1)
1-5: Wrap bare URLs in angle brackets to comply with markdown style guidelines.The new 2.3.0 changelog entries contain bare URLs that violate the markdown linting rule MD034 (no-bare-urls). While the existing 2.2.0 section follows the same pattern, it's preferable to wrap URLs in angle brackets for consistency with markdown best practices.
Apply this diff to wrap the URLs:
-## [2.3.0] - 2025-10-24 -* Fix issue #24: Add batch_send method to SendingApi, add models by @Ihor-Bilous in https://github.com/mailtrap/mailtrap-python/pull/47 -* Fix issue #42: Add GeneralApi, related models, examples, tests. by @Ihor-Bilous in https://github.com/mailtrap/mailtrap-python/pull/48 -* Fix issue #41: Add ContactExportsApi, related models, tests and examples by @Ihor-Bilous in https://github.com/mailtrap/mailtrap-python/pull/49 -* Fix issue #45: Add ContactEventsApi, related models, tests and examples by @Ihor-Bilous in https://github.com/mailtrap/mailtrap-python/pull/51 +## [2.3.0] - 2025-10-24 +* Fix issue #24: Add batch_send method to SendingApi, add models by @Ihor-Bilous in <https://github.com/mailtrap/mailtrap-python/pull/47> +* Fix issue #42: Add GeneralApi, related models, examples, tests. by @Ihor-Bilous in <https://github.com/mailtrap/mailtrap-python/pull/48> +* Fix issue #41: Add ContactExportsApi, related models, tests and examples by @Ihor-Bilous in <https://github.com/mailtrap/mailtrap-python/pull/49> +* Fix issue #45: Add ContactEventsApi, related models, tests and examples by @Ihor-Bilous in <https://github.com/mailtrap/mailtrap-python/pull/51>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
CHANGELOG.md(1 hunks)pyproject.toml(1 hunks)
🧰 Additional context used
🪛 markdownlint-cli2 (0.18.1)
CHANGELOG.md
2-2: Bare URL used
(MD034, no-bare-urls)
3-3: Bare URL used
(MD034, no-bare-urls)
4-4: Bare URL used
(MD034, no-bare-urls)
5-5: Bare URL used
(MD034, no-bare-urls)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (10)
- GitHub Check: Test python3.9 on macos-latest
- GitHub Check: Test python3.11 on windows-latest
- GitHub Check: Test python3.10 on windows-latest
- GitHub Check: Test python3.13 on windows-latest
- GitHub Check: Test python3.12 on windows-latest
- GitHub Check: Test python3.9 on windows-latest
- GitHub Check: Test python3.10 on windows-latest
- GitHub Check: Test python3.13 on windows-latest
- GitHub Check: Test python3.11 on windows-latest
- GitHub Check: Test python3.12 on windows-latest
🔇 Additional comments (2)
pyproject.toml (1)
3-3: Version bump to 2.3.0 is correctly applied.The version field update aligns with the CHANGELOG.md entry and follows the pyproject.toml format specification.
CHANGELOG.md (1)
1-5: Changelog entries accurately document the v2.3.0 release.The four entries correctly capture the batch_send method additions across SendingApi, GeneralApi, ContactExportsApi, and ContactEventsApi, with proper issue/PR references for traceability.
andrii-porokhnavets
left a comment
There was a problem hiding this comment.
Shouldn't we wait for the updated README?
|
@andrii-porokhnavets Release was already done, if we want one more it will be another one |
|
@VladimirTaytor Readme PR is merged, so we can maybe merge that as well and bump version |
Fix issue #54: Add SendingDomainsApi, related models, tests, examples
Motivation
We want to make new release
Changes
Summary by CodeRabbit