-
Notifications
You must be signed in to change notification settings - Fork 20
Include bin hash in cache key #228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Could you also compile the action and bump its version in package.json? |
Co-authored-by: Pavel Zwerschke <[email protected]>
@pavelzw minor bump for this? |
|
Sure 👍🏻 |
|
Is |
|
Yes seems like it 🤔 I nowadays just run the tests from GitHub ci |
|
|
hmm looked that one up somewhere, guess I was looking at the wrong fs package |
|
seems like regular readFile with no encoding should do the trick |
|
The ci failures look unrelated. I'll take a look at them later |
|
the remaining failing ci is tracked in #230 |
|
FWIW, this doesn't work as expected because a promise is interpolated into the cache key string rather than the value the promise resolves to, e.g. I see cache keys like: The issue is this bit of code added by 59b1132 Lines 43 to 45 in 7f29b8b
because |
Add sha256 hash of the micromamba binary to the cache key so broken environments created from previous versions won't be restored for a new version.
Closes #91