Remove feature toggle and update docstrings for staged data with tokens #2614
+103
−112
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexowens90
requested changes
Aug 29, 2025
| "Staging data with write() is deprecated. Use stage() instead.", | ||
| DeprecationWarning, | ||
| stacklevel=2, | ||
| ) |
There was a problem hiding this comment.
We need the same warning with append when incomplete=True
| Removes previous (non-snapshotted) versions from the database. | ||
| staged : bool, default=False | ||
| Whether to write to a staging area rather than immediately to the library. | ||
| See documentation on `finalize_staged_data` for more information. |
There was a problem hiding this comment.
I would keep a docstring for this argument, but say that it is deprecated and to use stage instead
G-D-Petrov
approved these changes
Aug 29, 2025
alexowens90
approved these changes
Aug 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement or fix?
#2461 introduced tokens for staged data behind a feature toggle.
This PR removes the feature toggle and updates the docstrings for the new API's. Also depecates write with parameter staged
Any other comments?
Checklist
Checklist for code changes...