Upgrade node version in CI to 24 #2636
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IvoDD
approved these changes
Sep 10, 2025
| return p | ||
| except AssertionError: | ||
| except AssertionError as ex: | ||
| print(repr(ex)) |
There was a problem hiding this comment.
Maybe use a logger.error() instead of printing to stdout?
.github/workflows/build_steps.yml
Outdated
| python -m pip install --force-reinstall --retries 3 --timeout 500 -r $GITHUB_WORKSPACE/build_tooling/${{matrix.python_deps}} | ||
| fi | ||
| python -m pip uninstall -y pytest-cpp || true # No longer works on 3.6 | ||
| # Downgrade to urllib3 1.23 to avoid breaking changes that affect azurite |
There was a problem hiding this comment.
Is this a leftover comment? Or we are somewhere explicitly downgrading?
There was a problem hiding this comment.
yeah it was a leftover, removed
phoebusm
approved these changes
Sep 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
What does this implement or fix?
-- This is fixed by upgrading the Node version and fixing how ports are provisioned for the Azurite sum
Any other comments?
Checklist
Checklist for code changes...