eir: Log image UEFI device paths #1036
Open
+84
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
no92
reviewed
Sep 17, 2025
| return &s; | ||
| } | ||
|
|
||
| struct UefiAllocator { |
There was a problem hiding this comment.
Might be nice to have a comment warning that these allocations should probably not survive past ExitBootServices.
|
|
||
| auto n = frg::basic_string_view<char16_t>{devPathUtf16}.size(); | ||
| frg::string<UefiAllocator> out{n}; | ||
| for (size_t i = 0; i < n; ++i) { |
There was a problem hiding this comment.
Having a helper function for this in helpers.hpp would be nicer than copy-pasting this code block, especially now that we can use the UefiAllocator with frg::string.
| }; | ||
|
|
||
| frg::string<UefiAllocator> devPathToString(efi_device_path_protocol *devPath) { | ||
| auto devPathUtf16 = devPathToText->convert_device_path_to_text(devPath, true, true); |
There was a problem hiding this comment.
We should gracefully handle this protocol not being present on funny UEFI implementations.
|
|
||
| // Get some essential protocols. | ||
| efi_guid devPathToTextGuid = EFI_DEVICE_PATH_TO_TEXT_PROTOCOL_GUID; | ||
| EFI_CHECK( |
There was a problem hiding this comment.
We should gracefully handle this protocol not being present on funny UEFI implementations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Small PR that helps with debugging on UEFI boot.