Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add multiple manager support #941

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 30, 2019
Merged

Add multiple manager support #941

merged 1 commit into from
Apr 30, 2019

Conversation

tobrun
Copy link
Member

@tobrun tobrun commented Apr 26, 2019

Closes #921

@tobrun tobrun added this to the annotation-future milestone Apr 26, 2019
@tobrun tobrun self-assigned this Apr 26, 2019
tobrun
tobrun commented Apr 26, 2019
View reviewed changes
LukasPaczos
LukasPaczos reviewed Apr 29, 2019
View reviewed changes
Copy link
Contributor

@LukasPaczos LukasPaczos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed, the ID_GENERATOR could be moved to either the child class or the CoreElementProvider (and making the provider a field at the same time) in order to remove the roundtripping between parent and child.

Also, the layer/source ID could be stored permanently, per instance in a non-static field, so that getters don't require string concatenation.

@tobrun tobrun force-pushed the tvn-multiple-manager branch from 2e97d48 to 7bc2f74 Compare April 29, 2019 18:14
@tobrun
Copy link
Member Author

tobrun commented Apr 29, 2019

Consolidated everything inside concrete instances of CoreElementProvider. Ready for another round of 👀 .

@tobrun tobrun force-pushed the tvn-multiple-manager branch from 7bc2f74 to e717e4e Compare April 29, 2019 18:19
LukasPaczos
LukasPaczos approved these changes Apr 30, 2019
View reviewed changes
Copy link
Contributor

@LukasPaczos LukasPaczos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A tiny bit more could've been moved to an abstract element provider, but generally LGTM 👍

@tobrun
Copy link
Member Author

tobrun commented Apr 30, 2019 •
edited
Loading

A tiny bit more could've been moved to an abstract element provider, but generally LGTM +1

In general yes, good to avoid duplication but since it's generated from a template file, updating code requires updating that one template file in a similar way as you would do with that abstract class. Developer flow wise that is kinda be the same.

@tobrun tobrun merged commit b028dff into master Apr 30, 2019
@tobrun tobrun deleted the tvn-multiple-manager branch April 30, 2019 08:23
This was referenced Jun 11, 2019
Closed
Closed
@tobrun tobrun mentioned this pull request Jun 27, 2019
Closed
@keinix keinix mentioned this pull request Aug 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@LukasPaczos LukasPaczos LukasPaczos approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@tobrun tobrun

Labels

annotation-plugin

Projects

None yet

Milestone

annotations-0.7.0

Development

Successfully merging this pull request may close these issues.

Multiple manager support

2 participants

@tobrun @LukasPaczos