Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Add DRYRUN flag to semver commands to allow checking tags without creating them - #28

Merged
markchalloner merged 1 commit into
markchalloner:masterfrom
oliviabarrick:master
Oct 24, 2018
Merged

Add DRYRUN flag to semver commands to allow checking tags without creating them#28
markchalloner merged 1 commit into
markchalloner:masterfrom
oliviabarrick:master

Conversation

@oliviabarrick

@oliviabarrick oliviabarrick commented Sep 4, 2018

Copy link
Copy Markdown
Contributor

This is useful to be able to update files and create a custom release commit that includes the version before tagging it.

Example: https://github.com/justinbarrick/fluxcloud/blob/master/Makefile#L9-L10

@markchalloner

Copy link
Copy Markdown
Owner

I like this idea.

I think the trigger would be better as a named argument e.g. git-semver patcch -d rather than an environmental variable, as it is then can be documented in the usage.

If you agree then please rebase on latest master (has named arguments to use as an example).

Thanks!

@oliviabarrick

Copy link
Copy Markdown
Contributor Author

Should be changed now! I'm supporting both --dryrun and -d for clarity.

@markchalloner

Copy link
Copy Markdown
Owner

Looks good thanks for the PR.

@markchalloner
markchalloner merged commit 4a00f79 into markchalloner:master Oct 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants