Fix stripping VERSION_PREFIX from major versions to prevent creating versions with double versions. - #33
Merged
markchalloner merged 1 commit intoOct 24, 2018
Conversation
…versions with double versions. I had a `VERSION_PREFIX=v` which caused my versions to have two "v": ``` ➜ fluxcloud git:(master) ✗ git semver --dryrun patch vv0.2.11 ➜ fluxcloud git:(master) ✗ ``` Bash does not interpolate variables inside of single quotes, so this fixes the sed command in version-parse-major to use double quotes so that the VERSION_PREFIX gets properly stripped.
Owner
|
Thanks @justinbarrick, good catch. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I had a
VERSION_PREFIX=vwhich caused my versions to have two "v":Bash does not interpolate variables inside of single quotes, so this fixes the sed
command in version-parse-major to use double quotes so that the VERSION_PREFIX
gets properly stripped.