Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix lexer and tokenizer to retain line breaks properly #2341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 6, 2022
Merged

Fix lexer and tokenizer to retain line breaks properly #2341

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
7183372
Fix lexer and tokenizer to retain line breaks properly
phillipb Dec 31, 2021
8e1c316
Add test for bug
phillipb Dec 31, 2021
1317eb0
Check for line breaks not just spaces
phillipb Dec 31, 2021
d28368e
Fix lint
phillipb Dec 31, 2021
4b2185a
Fix spacing in test
phillipb Jan 4, 2022
bd3e980
clean up code
UziTech Jan 4, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix lint
  • Loading branch information
@phillipb
phillipb committed Dec 31, 2021
commit d28368e0df01be09b9d49d94b835ffccc2933776
4 changes: 2 additions & 2 deletions src/Lexer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -154,8 +154,8 @@ export class Lexer {
src = src.substring(token.raw.length);
if (token.raw.length === 1 && tokens[tokens.length - 1]) {
// if there's a single \n as a spacer, it's terminating the last line, so move it there so that we don't get unecessary paragraph tags
tokens[tokens.length - 1].raw = `${tokens[tokens.length - 1].raw}\n`
continue
tokens[tokens.length - 1].raw = `${tokens[tokens.length - 1].raw}\n`;
continue;
}
if (token.type) {
tokens.push(token);
Expand Down
6 changes: 3 additions & 3 deletions src/Tokenizer.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,16 +307,16 @@ export class Tokenizer {
const hasMultipleLineBreaks = spacers.every(t => {
const chars = t.raw.split('');
let lineBreaks = 0;
for (let char of chars) {
for (const char of chars) {
if (char === '\n') {
lineBreaks += 1;
}
if (lineBreaks > 1) {
return true
return true;
}
}

return false
return false;
});

if (!list.loose && spacers.length && hasMultipleLineBreaks) {
Expand Down
4 changes: 2 additions & 2 deletions test/unit/Lexer-spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -344,7 +344,7 @@ lheading 2
tokens:
jasmine.arrayContaining([
jasmine.objectContaining({
raw: "T\nh\n"
raw: 'T\nh\n'
}),
{ type: 'hr', raw: '---' }
])
Expand Down Expand Up @@ -599,7 +599,7 @@ paragraph
jasmine.objectContaining({
type: 'list',
raw: '- item 2'
}),
})
])
})
]
Expand Down