Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Replace DotNetZip with Zlib.Portable #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

Replace DotNetZip with Zlib.Portable #16

wants to merge 3 commits into from

Conversation

KevinBalz
Copy link
Contributor

Removed zlib source files and added Zlib.Portable Nuget.

@marshallward
Copy link
Owner

Thanks for this.
I will need to give it a try before I can move ahead, so it might be a bit
slow.

I must admit that I am a bit worried about adding a new dependency, which
might just add to the difficulty of using it. But maybe I am worrying too
much; getting something like MonoGame built is far more difficult!

As for using NuGet - I have added support but don't actually use it much
myself. Does this need to be included in the TiledSharp.nuspec file?

On Sun, Apr 12, 2015 at 9:06 PM, Kevin Balz [email protected]
wrote:

Removed zlib source files and added Zlib.Portable Nuget.

You can view, comment on, or merge this pull request online at:

#16
Commit Summary

  • Add Nuget packages to gitignore
  • Replace DotNetZip with Zlib.Portable

File Changes

Patch Links:

—
Reply to this email directly or view it on GitHub
#16.

@marshallward
Copy link
Owner

Also, I haven't looked into the state of gzip/zlib compatibility with the standard .NET libraries. Maybe this is an option, which eliminates the entire dependency issue?

@KevinBalz
Added dependencies to .nuspec
c568683 
Updated depencies to include Zlib.Portable
@KevinBalz
Copy link
Contributor Author

You're right, you must add dependencies to the nuspec, haven't thought about that. src: https://docs.nuget.org/create/creating-and-publishing-a-package (example .nuspec) .
I'm no nuget expert either, so i will look for a way if it works.
And System.IO.Compression would be sufficient if Tiled would only support gzip compression, zlib compression seems to be different, but i can't tell how and why as im no compression expert also.

@marshallward
Copy link
Owner

I have read that zlib and gzip libraries can often be used together, since zlib is capable of writing gzip headers, and gzip is capable of understanding the DEFLATE algorithm. But there have also been reports of bloated zlib files under .NET, and unfortunately I never really learned much about the issue.

Anyway, it is probably best to keep using a zlib-dedicated library.

BTW the Zlib.Portable README says that its work is being sent to the official DotNetZip repository. Do you know if there's any advantage to using one vs the other?

(Also, I am glad to see that DotNetZip is still being maintained!)

PS: I've emailed AdvancedREI to see which one they would recommend.

@marshallward
Copy link
Owner

Just heard back from Robert McLaws, Zlib.Portable maintainer (that was fast!), he suggested going with the DotNetZip version.
Can you give that one a try and see if it still works with PCLs?

@KevinBalz
Copy link
Contributor Author

I have problems findng the DotNetZip version ( there are a lot of packages named Zlib.Portable). To which one are you referreing to?

@marshallward
Copy link
Owner

Yeah... I see what you mean now.

Zlib.Portable's README points to the 2011 release, which is I was already
using and therefore does not support PCLs.

The DotNetZip version of NuGet does not have any record of patches or
contributions from AdvancedREI, which means this is not where they are
sending their patches (unless they are just sending raw patches via email).

And the NuGet version of DotNetZip does not appear to be any more
"official" anyway, but rather an effort to keep the project alive by new
people.

I will contact Robert McLaws again, and find out to which repo they have
been sending their patches.

Very sorry for making this more complicated than it probably needs to be.
It's only that if I do add an external dependency, then I want to make sure
it's the right one to add!

On Tue, Apr 14, 2015 at 5:58 PM, Kevin Balz [email protected]
wrote:

I have problems findng the DotNetZip version ( there are a lot of packages
named Zlib.Portable). To which one are you referreing to?

—
Reply to this email directly or view it on GitHub
#16 (comment)
.

@marshallward marshallward mentioned this pull request Apr 5, 2016
Open
@marshallward marshallward mentioned this pull request Oct 19, 2016
Open
@marshallward
Copy link
Owner

The new version does not require an external zlib library, so I'll probably close this issue if there are no problems.

@marshallward
Copy link
Owner

Closing this, since an external zlib library is no longer necessary. Issues with the zlib changes can be handled in separate issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@KevinBalz @marshallward