-
Notifications
You must be signed in to change notification settings - Fork 7
Handling several examples #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Thank you for your pull request! I sadly don't have time for AoC this year, which is why this repo has been a bit dead. However, I'll try to look at your PR asap, though it may only happen after Christmas. I am certainly okay with the idea of supporting multiple examples, as that is a pain point I ran into myself several times. Does your PR include examples present in part 2 of the challenge? Or does it only look at the public part of the page for now? |
I changed the mix aoc.get task so that it downloads each example it can find. I did not explicitly mentioned, but with this commit the private function |
- This gives the user a hint that multiple exmplae_string based tests may be provided.
I went through the updated code and made a few changes. Most changes are quite minor. The two most significant changes are:
Let me sure to know if you disagree with any of these. If you don't, I think I can merge & release this as is 😄. |
I agree with all of your changes. Please go on and thank you for the nice work! |
Thank you for the contribution! I'll make one more change: I'll publish this as version 5.0, as the name change of the example files will cause people's tests to break if they don't run |
Added support to several examples (both on
Helpers
andaoc.get
mix task). Upgraded deps. Slight change to embedded template.I hope to have explained everything well-enough in the Changelog. I hope each commit is clean and focused enough, as well.
Furthermore, I am using this version myself and I found it extremely useful on days like 16 or 15 where there are several useful example or days like 21 where the example is not the first "pre code" HTML child.