Thanks to visit codestin.com
Credit goes to github.com

Skip to content

add workflow for building artifacts #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Apr 26, 2021
Merged

add workflow for building artifacts #57

merged 4 commits into from
Apr 26, 2021

Conversation

jimustafa
Copy link
Contributor

Attempts to close #52 and tries to address #29. This PR does several things:

  • creates a Makefile for downloading the fonts
  • adds instructions in the README for configuring the fonts with fontconfig
  • creates a requirements directory for managing (with pip-tools) the dependencies needed to build the artifacts
  • creates a workflow for automatically building the artifacts as part of CI/CD
  • creates a Makefile in the root directory for running a variety of tasks (eg, building the fonts and figures)

@jimustafa
Copy link
Contributor Author

This PR may also partially close #32.

@rougier
Copy link
Member

rougier commented Apr 15, 2021

Impressive, many thanks. I also need to cleanup scripts because I may have commented some parts in a few of them and I'm not sure all the figures are generated at once. Did you test the workflow locally? Did you encounter any errors with missing figures?

@jimustafa
Copy link
Contributor Author

Yes, the workflow appears to be working, both locally, and running as a GitHub Action. So far, the cheat sheet is being built, but, yeah, some figures necessary for the handouts are not being generated (specifically, those in scripts/sine.py). Also, it looks like some of the figures should be post-processed with pdfcrop, as suggested by one of your comments in #32.

@lgtm-com
Copy link

lgtm-com bot commented Apr 16, 2021

This pull request introduces 4 alerts and fixes 1 when merging d074da7 into 92d26b5 - view on LGTM.com

new alerts:

  • 4 for Variable defined multiple times

fixed alerts:

  • 1 for Variable defined multiple times

@rougier rougier merged commit bebdae0 into matplotlib:master Apr 26, 2021
This was referenced Apr 26, 2021
Closed
Closed
This was referenced Aug 24, 2021
Closed
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

A Suggestion about CI/CD.
2 participants
@jimustafa @rougier