-
Notifications
You must be signed in to change notification settings - Fork 909
Automatically generated logo for the cheatsheets #61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
* credit to Tim Hoffmann as the original author of the script
Thanks. I don't think we need to tweak the logo. How different are the two logos (with Carlito and Calibri)? |
Hey @rougier. Have you been able to inspect the build artifacts generated with the GitHub Actions workflow? The cheatsheets build for this PR incorporates the generated logo. |
I've built locally the cheatsheets and handouts and they look ok to me. I did not test yet your PR. |
OK, I added a few commits, to do the following:
Regarding the copyright notice... It seems that it should read Another question... There appears to be an inconsistency between the license file in this repo (BSD2) and the license statements in the cheatsheets and handouts (CC-BY); maybe that is fine. However, there are also different licenses for the cheatsheets and handouts, with some released under |
Good day @rougier. I updated the copyright notices and normalized the licensing in a manner consistent with my previous comment. Please review and let me know what, if anything, needs to be changed. Thanks! |
Looks good to me but the grant number (my fault). After that I think we can merge. |
Thanks @rougier for the review. I removed the grant number placeholder, and corrected the capitalization of NumFOCUS. |
Many, many thanks. I think we're good to go! |
A major problem with autogenerating the logo is that the font Calibri is no available. Thus the logo has the wrong font, which is a major branding issue. I think the correct solution would be to take the logo as is and overlay the "Cheat Sheet" and version tests in LaTeX. |
The "grant #" was a Numfocus Small Development grant , if you want something to acknowledge. |
As has been discussed in #32, there is a need to keep the
matplotlib
logo in the cheatsheets up to date with the correct version in the tag line. This PR does a couple of things:matplotlib
version, updates the dependencies, and simplifies the requirements specificationmatplotlib
logo, originally written by @timhoffmmatplotlib
version in the tag lineThere may be some small tweaks to make the logo more closely resemble the one by @rougier; well, maybe also a big tweak, as the font is currently Carlito, not Calibri.