Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Automatically generated logo for the cheatsheets #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 16, 2021

Conversation

jimustafa
Copy link
Contributor

As has been discussed in #32, there is a need to keep the matplotlib logo in the cheatsheets up to date with the correct version in the tag line. This PR does a couple of things:

  • upgrades and pins the matplotlib version, updates the dependencies, and simplifies the requirements specification
  • adds a script for generating the matplotlib logo, originally written by @timhoffm
  • modifies the script to include "Cheat sheets" and the matplotlib version in the tag line

There may be some small tweaks to make the logo more closely resemble the one by @rougier; well, maybe also a big tweak, as the font is currently Carlito, not Calibri.

@rougier
Copy link
Member

rougier commented May 19, 2021

Thanks. I don't think we need to tweak the logo. How different are the two logos (with Carlito and Calibri)?

@jimustafa
Copy link
Contributor Author

Hey @rougier. Have you been able to inspect the build artifacts generated with the GitHub Actions workflow? The cheatsheets build for this PR incorporates the generated logo.

@rougier
Copy link
Member

rougier commented May 20, 2021

I've built locally the cheatsheets and handouts and they look ok to me. I did not test yet your PR.
Also, we need to modify the copyright notice (replace my name by Matplotlib)

@jimustafa
Copy link
Contributor Author

OK, I added a few commits, to do the following:

  • fix the requirements Makefile
  • update the matplotlib version tag in the handouts
  • configure bump2version to automatically update the matplotib version string in the necessary files when the matplotlib dependency is upgraded

Regarding the copyright notice... It seems that it should read Copyright (c) 2021 Matplotlib Development Team based on the license file in the matplotib repo. Is this, in fact, how it should be done?

Another question... There appears to be an inconsistency between the license file in this repo (BSD2) and the license statements in the cheatsheets and handouts (CC-BY); maybe that is fine. However, there are also different licenses for the cheatsheets and handouts, with some released under CC-BY 4.0 and other under CC-BY International 4.0. Additionally, the cheatsheets do not acknowledge support from NumFocus Grant #12345. Can these be normalized?

@jimustafa
Copy link
Contributor Author

Good day @rougier. I updated the copyright notices and normalized the licensing in a manner consistent with my previous comment. Please review and let me know what, if anything, needs to be changed. Thanks!

@rougier
Copy link
Member

rougier commented Jun 14, 2021

Looks good to me but the grant number (my fault). After that I think we can merge.

@jimustafa
Copy link
Contributor Author

Thanks @rougier for the review. I removed the grant number placeholder, and corrected the capitalization of NumFOCUS.

@rougier
Copy link
Member

rougier commented Jun 16, 2021

Many, many thanks. I think we're good to go!

@timhoffm
Copy link
Member

A major problem with autogenerating the logo is that the font Calibri is no available. Thus the logo has the wrong font, which is a major branding issue.

I think the correct solution would be to take the logo as is and overlay the "Cheat Sheet" and version tests in LaTeX.

@story645
Copy link
Member

The "grant #" was a Numfocus Small Development grant , if you want something to acknowledge.

@jimustafa jimustafa mentioned this pull request Oct 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants