switch to Font Awesome for icons and brand logos #71
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice, did not know font awesome was include in texlive. LGTM. |
|
Yeah, me neither. Always fun to discover a new package. A couple of the icons are slightly different than what was previously used, most notably the GitHub brand icon. |
|
Hey @rougier, wanted to check if this PR was OK to merge. Let me know if anything needs to be addressed. |
|
I forget what the merge policy is here, is it just @rougier? |
|
ooops, sorry, meant to enter a comment that these look good, and nice to get rid of a repo dependency... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the
fontawesome5package in place of the icons and brand logos committed to the repository.