Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Initial adaptation from Jupyter to matplotlib #1

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 20, 2016

Conversation

mdboom
Copy link
Member

@mdboom mdboom commented Jul 17, 2016

This is a first pass at adapting the Jupyter content for matplotlib.

more legal and financial decisions and interacts with other
institutions, we see a need for a more formal governance model. Moving
forward The Project leadership will consist of a Steering Council with
the power to appoint final decisions to an individual. We view this
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Something is wrong here--I'm not sure what you intended to say.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yeah, I'm not sure how "with the power to appoint final decisions to an individual" is better than "a BDFL", as was in the original text from jupyter.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, we started trying to remove the BDFL and then went back on it, but forget to revert this change.

@dopplershift
Copy link
Contributor

There's a phrase "The BDFL can appointing his/her successor" (came over from Jupyter, so not in the diff) that should also be cleaned up.

Otherwise, I have no problem with this. I think the model has served Jupyter well to this point.

@mdboom
Copy link
Member Author

mdboom commented Jul 19, 2016

I've just pushed some changes that I hope address the comments here.

Additionally, on a second read I decided to elaborate on the history section a bit. It draws the linkage from John through Mike to Thomas, so it isn't quite so jarring when Thomas is first mentioned in the BDFL section.

- Thomas Caswell
- Michael Droettboom
- Phil Elson
- Eric Firing
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Subcommittee members must have contiguous last initials, apparently.

project affiliated with the 501c3 NumFocus Foundation. The goal of The
Project is to develop open source software and deploy open and public
websites and services for data visualization. The Software developed
by The Project is released under the BSD (or similar permissive) open
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this covers everything under the Matplotlib GitHub organization, basemap bundles GEOS (LGPL) and GMT data (GPL), and natgrid's license is "Restricted" (whatever that means), which I think don't strictly fall under "permissive".

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The only weird thing about natgrid is src/nncrunch.c. The main source is BSD-2 clause and @jswhit 's code is MIT (I think?).

Is there a way build basemap without bundling those dependencies?

thoughts @WeatherGod ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

with respect to basemap and GEOS, the source tree merely vendors a version of the library, but doesn't require that it be used, IIRC. As for the GMT data, I have always been highly skeptical of the GPL claim for the data. The software (which is not included) is GPL, and that is fine, but I have had a hard time believing anyone can even apply GPL to a dataset.

As for unbundling the data from basemap, it is technically possible (conda-forge supposedly does it), but no one has submitted a patch upstream to do it there as well. However, basemap is pretty much useless without that data. It is theoretically possible to use a different dataset (Cartopy uses another dataset), but converters would need to be written to generate them into the internal format used by basemap (which is pretty much undocumented).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we just explicitly exclude basemap as falling under different rules (wrt licensing) so we can move forward with everything else?

@mdboom mdboom merged commit ecce275 into matplotlib:master Sep 20, 2016
@mdboom
Copy link
Member Author

mdboom commented Sep 20, 2016

All: I've made the final "simple" corrections and merged this.

I think it was most important to begin to have something in effect than waiting for perfect. Specifically, I think @Carreau's discussion about "broader" community, and @OceanWolf's points about more specifically defining certain groups are good points, and those discussions can continue in other issues and PRs.

Thanks everyone for helping with this, and congrats, @tacaswell.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.