Thanks to visit codestin.com
Credit goes to github.com

Skip to content

support double click events #446

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Mar 31, 2022
Merged

support double click events #446

merged 2 commits into from
Mar 31, 2022

Conversation

ianhi
Copy link
Collaborator

@ianhi ianhi commented Mar 31, 2022

closes: #261 attn @nvaytet

@martinRenou for version numbers what do we do here? I think we need to bump package.json

ipympl/package.json

Line 3 in 21a1c8d

"version": "0.10.5",

to either 0.11.0 or 0.10.6 and also bump the python version. Is there anything we can do here to ameliorate the patch version incompatibility (#416)?

@github-actions
Copy link
Contributor

Binder 👈 Launch a binder notebook on branch ianhi/ipympl/dblclick

@ianhi
Copy link
Collaborator Author

ianhi commented Mar 31, 2022

Ok I'm out of ideas for fixing this error:

[webpack-cli] Error: error:0308010C:digital envelope routines::unsupported
    at new Hash (node:internal/crypto/hash:67:19)
    at Object.createHash (node:crypto:130:10)
    at BulkUpdateDecorator.hashFactory (/home/runner/work/ipympl/ipympl/node_modules/webpack/lib/util/createHash.js:155:18)
    at BulkUpdateDecorator.digest (/home/runner/work/ipympl/ipympl/node_modules/webpack/lib/util/createHash.js:80:21)
    at /home/runner/work/ipympl/ipympl/node_modules/webpack/lib/DefinePlugin.js:595:38
    at _next31 (eval at create (/home/runner/work/ipympl/ipympl/node_modules/tapable/lib/HookCodeFactory.js:19:10), <anonymous>:42:1)
    at _next9 (eval at create (/home/runner/work/ipympl/ipympl/node_modules/tapable/lib/HookCodeFactory.js:19:10), <anonymous>:97:1)
    at Hook.eval [as call] (eval at create (/home/runner/work/ipympl/ipympl/node_modules/tapable/lib/HookCodeFactory.js:19:10), <anonymous>:119:1)
    at Hook.CALL_DELEGATE [as _call] (/home/runner/work/ipympl/ipympl/node_modules/tapable/lib/Hook.js:14:14)
    at Compiler.newCompilation (/home/runner/work/ipympl/ipympl/node_modules/webpack/lib/Compiler.js:1053:26) {
  opensslErrorStack: [ 'error:03000086:digital envelope routines::initialization error' ],
  library: 'digital envelope routines',
  reason: 'unsupported',
  code: 'ERR_OSSL_EVP_UNSUPPORTED'
}

@martinRenou any thoughts? Everything on the internet seems to point this being an issue with node 17 but above commits moving to node 16 didn't seem to help :(

@ianhi
bump webpack version
1e110c9 
Fixes `ERR_OSSL_EVP_UNSUPPORTED` because openssl 3
no longer provides md4.
https://github.com/webpack/webpack/releases/tag/v5.61.0
@ianhi
Copy link
Collaborator Author

ianhi commented Mar 31, 2022

bumping webpack version was the solution

@ianhi ianhi mentioned this pull request Mar 31, 2022
Closed
@ianhi ianhi merged commit 01511c1 into matplotlib:main Mar 31, 2022
@ianhi ianhi deleted the dblclick branch March 31, 2022 21:29
@ianhi
Copy link
Collaborator Author

ianhi commented Mar 31, 2022

@nvaytet will release soon hopefully - going to try to work out whats happening with #416 first

@martinRenou
Copy link
Member

Sorry I missed your question. I will push a PR for that OpenSSL issue, we fixed it in multiple places.

@nvaytet
Copy link

nvaytet commented Apr 1, 2022

@ianhi awesome! thanks :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Double-click events are not recognised
3 participants
@ianhi @martinRenou @nvaytet