Close widget when figure is closed from python #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This ensures that the figure in the notebook is closed correctly when closed
I.e.
creates a figure and then in a new cell assuming this is the first figure we can close it with:
Currently this does not have any visual effect. This change ensures that the figure is closed in the notebook as expected.
I have removed the
self._send_event('close')
because it seems to trigger a no comms warning. As I understand it this no longer needed anyway as the widget handles the closing.