Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Remove unnecessary dependency ipython_genutils #558

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 2, 2024
Merged

Remove unnecessary dependency ipython_genutils #558

merged 1 commit into from
Jul 2, 2024

Conversation

randolf-scholz
Copy link
Contributor

@randolf-scholz randolf-scholz commented Jul 2, 2024 •
edited
Loading

I noticed this project depends on ipython_genutils, which was last updated in 2017.
Moreover, the only used thing from ipython_genutils was ipython_genutils.py3compat.string_types, which happens to be the tuple (str,).

from ipython_genutils.py3compat import string_types
assert string_types == (str,)  # ✅
assert string_types[0] is str  # ✅

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 2, 2024

Binder 👈 Launch a binder notebook on branch randolf-scholz/ipympl/remove_ipython_genutils

martinRenou
martinRenou approved these changes Jul 2, 2024
View reviewed changes
Copy link
Member

@martinRenou martinRenou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@martinRenou martinRenou merged commit 564cf6d into matplotlib:main Jul 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinRenou martinRenou martinRenou approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@randolf-scholz @martinRenou