Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Fix save #93

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 21, 2019
Merged

Fix save #93

merged 1 commit into from
Jun 21, 2019

Conversation

martinRenou
Copy link
Member

@martinRenou martinRenou commented Jun 21, 2019

The "diff" image was saved after pressing the download button, not the actual plot

@SylvainCorlay SylvainCorlay merged commit febd3ee into matplotlib:master Jun 21, 2019
@tfblum
Copy link

tfblum commented Sep 17, 2019

The code as written when this file was changed shows the filename always ending with '.png' but shouldn't this change depending on the default value listed in the matplotlibrc file?

@thomasaarholt
Copy link
Contributor

This is a good point. The relevant entry is in plt.rcParams['savefig.format'], but I'm not sure how that translates to the javascript code.

@martinRenou martinRenou deleted the fix_save branch September 18, 2019 07:34
@martinRenou
Copy link
Member Author

Do you mind opening a specific issue for this? :)

@thomasaarholt
Copy link
Contributor

Done #138

QuLogic added a commit to QuLogic/matplotlib that referenced this pull request Apr 4, 2020
QuLogic added a commit to QuLogic/matplotlib that referenced this pull request Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants