Merge pull request #13465 from jklymak/fix-polar-bottom

dstansby · web-flow · commit 7dca1bf0a666 · 2019-02-23T10:23:48.000Z
FIX: polar set_rlim allow bottom-only call
diff --git a/lib/matplotlib/projections/polar.py b/lib/matplotlib/projections/polar.py
@@ -1189,9 +1189,8 @@ def set_ylim(self, bottom=None, top=None, emit=True, auto=False,
                                  'argument and kwarg "ymax"')
             else:
                 top = ymax
-        if top is None and len(bottom) == 2:
-            top = bottom[1]
-            bottom = bottom[0]
+        if top is None and np.iterable(bottom):
+            bottom, top = bottom[0], bottom[1]
 
         return super().set_ylim(bottom=bottom, top=top, emit=emit, auto=auto)
 
diff --git a/lib/matplotlib/tests/test_axes.py b/lib/matplotlib/tests/test_axes.py
@@ -795,6 +795,27 @@ def test_polar_theta_limits():
             ax.yaxis.set_tick_params(label2On=True, rotation='auto')
 
 
+@check_figures_equal(extensions=["png"])
+def test_polar_rlim(fig_test, fig_ref):
+    ax = fig_test.subplots(subplot_kw={'polar': True})
+    ax.set_rlim(top=10)
+    ax.set_rlim(bottom=.5)
+
+    ax = fig_ref.subplots(subplot_kw={'polar': True})
+    ax.set_rmax(10.)
+    ax.set_rmin(.5)
+
+
+@check_figures_equal(extensions=["png"])
+def test_polar_rlim_bottom(fig_test, fig_ref):
+    ax = fig_test.subplots(subplot_kw={'polar': True})
+    ax.set_rlim(bottom=[.5, 10])
+
+    ax = fig_ref.subplots(subplot_kw={'polar': True})
+    ax.set_rmax(10.)
+    ax.set_rmin(.5)
+
+
 @image_comparison(baseline_images=['axvspan_epoch'])
 def test_axvspan_epoch():
     from datetime import datetime
