FIX: polar set_rlim allow bottom-only call #13465
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b17826c to
280b9a1
Compare
timhoffm
reviewed
Feb 19, 2019
lib/matplotlib/projections/polar.py
Outdated
| if top is None and len(bottom) == 2: | ||
| top = bottom[1] | ||
| bottom = bottom[0] | ||
| if top is None: |
There was a problem hiding this comment.
set_xlim uses
if right is None and np.iterable(left):
left, right = left
I think it's reasonable to use the same pattern here.
Note: This will explicitly fail set_rlim((1, 2, 3)). Your code would let that pass, and I assume it would have failed later on, since the assumption from here on is that bottom is a scalar.
04288c5 to
907067a
Compare
timhoffm
approved these changes
Feb 19, 2019
|
@QuLogic I think you recently did heavy polar work. Is this fix OK? |
dstansby
approved these changes
Feb 23, 2019
meeseeksmachine
pushed a commit
to meeseeksmachine/matplotlib
that referenced
this pull request
Feb 23, 2019
|
Something went wrong ... Please have a look at my logs. |
timhoffm
added a commit
that referenced
this pull request
Feb 23, 2019
…465-on-v3.1.x Backport PR #13465 on branch v3.1.x (FIX: polar set_rlim allow bottom-only call)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
closes #13464
Not sure this is the canonical way to do this. Improvements welcome.
Should obviously get a test so this doesn't get missed again.PR Checklist