Merge pull request #17956 from dopplershift/mac-version-check

dstansby · web-flow · commit d53b16c1075b · 2020-07-25T18:46:22.000+01:00
ENH: Add version check for mac sdk version
diff --git a/setupext.py b/setupext.py
@@ -657,6 +657,7 @@ def get_extensions(self):
             'src/_macosx.m'
             ]
         ext = Extension('matplotlib.backends._macosx', sources)
+        ext.extra_compile_args.extend(['-Werror=unguarded-availability'])
         ext.extra_link_args.extend(['-framework', 'Cocoa'])
         if platform.python_implementation().lower() == 'pypy':
             ext.extra_compile_args.append('-DPYPY=1')
diff --git a/src/_macosx.m b/src/_macosx.m
@@ -1184,8 +1184,10 @@ -(void)save_figure:(id)sender
     rect.size.height = 0;
     rect.origin.x += height;
     NSTextView* messagebox = [[NSTextView alloc] initWithFrame: rect];
-    messagebox.textContainer.maximumNumberOfLines = 2;
-    messagebox.textContainer.lineBreakMode = NSLineBreakByTruncatingTail;
+    if (@available(macOS 10.11, *)) {
+        messagebox.textContainer.maximumNumberOfLines = 2;
+        messagebox.textContainer.lineBreakMode = NSLineBreakByTruncatingTail;
+    }
     [messagebox setFont: font];
     [messagebox setDrawsBackground: NO];
     [messagebox setSelectable: NO];

Original file line number	Diff line number	Diff line change
`@@ -657,6 +657,7 @@ def get_extensions(self):`
`657`	`657`	`'src/_macosx.m'`
`658`	`658`	`]`
`659`	`659`	`ext = Extension('matplotlib.backends._macosx', sources)`
	`660`	`+ ext.extra_compile_args.extend(['-Werror=unguarded-availability'])`
`660`	`661`	`ext.extra_link_args.extend(['-framework', 'Cocoa'])`
`661`	`662`	`if platform.python_implementation().lower() == 'pypy':`
`662`	`663`	`ext.extra_compile_args.append('-DPYPY=1')`