move general check() method of optional backend to base class

megies · megies · commit fc759eebe6ce · 2013-08-27T00:16:45.000+02:00
also split up the if/else in 3 branches to show a separate message if an
configuration file backend opt-out was overridden by a forced backend
install
diff --git a/setupext.py b/setupext.py
@@ -467,6 +467,21 @@ def get_config(self):
             self.optional = False
         return self.install
 
+    def check(self):
+        """
+        This method should be called using super() even when overriding this
+        method in a base class to check for a opt-out in the config file.
+        """
+        if self.get_config() is True:
+            return "installing"
+        else:
+            # Some backend extensions (e.g. Agg) need to be built for certain
+            # other GUI backends (e.g. TkAgg) even when manually disabled
+            if self.force is True:
+                return "installation is forced (overriding configuration)"
+            else:
+                raise CheckFailed("skipping due to configuration")
+
 
 class Platform(SetupPackage):
     name = "platform"
@@ -981,15 +996,6 @@ def get_install_requires(self):
 class BackendAgg(OptionalBackendPackage):
     name = "agg"
 
-    def check(self):
-        # The Agg backend extension needs to be built even
-        # for certain GUI backends, such as TkAgg
-        config = self.get_config()
-        if config is False and self.force is False:
-            raise CheckFailed("skipping due to configuration")
-        else:
-            return "installing"
-
     def get_extension(self):
         sources = [
             "src/mplutils.cpp",
