-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Gridspec tutorial #11800
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Some of the plots looks much better on my computer but some of the plots get warnings with both constrained_layout and tight_layout. I believe that the problem is that some axes collapses under constrained layout ( I believe jklymak added that feature recently) and the new warnings in tight_layout. |
I believe the issue where in annotations, see #11801 There are also some other smaller errors in the tutorial that I can fix later. |
Well it’s strange that it seems to work locally but is broken at the docs renderer. I’ve also never quite seen axes collapse like that before so it’s a good error to track down. But I can’t look at it for a few days.... |
How many more artists have the same problem with |
Not sure. We should be sure to add tests for these so they get caught. I’m also a little concerned that now we are playing whack a mole. The fundamental problem was the change that added all artiss to the ax.get_tightbbox stack. Before it was just axes and their labels. Perhaps that was a mistake, though I think overall it is the right choice. |
I guess what’s needed is a test in one or both of the layout managers for every artist that we have and make sure they look good. I guess another issue is the same test(s) should be run interactively maybe just by hand to make sure zooming and figure resize work well. Of course that may not catch all the problems but it’d have caught the annotation bug. I can take a crack at this when I’m back or someOne could do so. Also on the todo list is improving the documentation on layout managers to make sure set_in_layout is properly explained. |
I have started to write some tests that test the interactive behavior. I don't get pytest to work though... |
I don't think there are any action items on this one. Feel free to re-open if I'm mistaken... |
Whats going on with the gridspec tutorial in the dev documentation?
The fourth figure look really bad and some other don't look good. The figures look good when I run the file my self.
It seems that constrained layout don't work as expected when rendering the documentation.
The text was updated successfully, but these errors were encountered: