Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Deprecate unused testing cleanup mechanisms #14329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
timhoffm opened this issue May 26, 2019 · 2 comments
Closed

Deprecate unused testing cleanup mechanisms #14329

timhoffm opened this issue May 26, 2019 · 2 comments
Labels
status: won't or can't fix topic: testing

Comments

@timhoffm
Copy link
Member

timhoffm commented May 26, 2019 •
edited
Loading

The class matplotlib.testing.decorators.CleanupTestCase and the decorator matplotlib.testing.decorators.cleanup are not used in the code base. We have an automatic cleanup via an auto-used fixture instead.

Can we deprecate them or are they considered part of the user-facing API for testing?
@anntzer
Copy link
Contributor

anntzer commented May 26, 2019

matplotlib.testing is written in a (somewhat) testing-framework-agnostic way. I don't think pytest really risks going away anytime soon, but I think it would be nice to keep some equivalent functionality that's independent of pytest (in fact I have a PR in the works to make more of the testing tooling independent of pytest, while makings things shorter :)).

@anntzer anntzer mentioned this issue May 26, 2019
Merged
6 tasks
@anntzer anntzer mentioned this issue Jun 17, 2019
Closed
6 tasks
@SidharthBansal SidharthBansal mentioned this issue Apr 6, 2020
Closed
6 tasks
@jklymak
Copy link
Member

jklymak commented Apr 7, 2020

@anntzer has plans for this so lets keep around.

@jklymak jklymak closed this as completed Apr 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
status: won't or can't fix topic: testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Deprecate unused testing cleanup mechanisms SidharthBansal/matplotlib
4 participants
@anntzer @jklymak @timhoffm @dstansby