Thanks to visit codestin.com
Credit goes to github.com

Skip to content

Inconsistent kwarg naming between step() and fill_between() #15085

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
andrzejnovak opened this issue Aug 19, 2019 · 4 comments
Closed

Inconsistent kwarg naming between step() and fill_between() #15085

andrzejnovak opened this issue Aug 19, 2019 · 4 comments
Labels
API: consistency status: inactive Marked by the “Stale” Github Action

Comments

@andrzejnovak
Copy link
Contributor

Calling step style is using a different kwarg name in step() and `fill_between() i.e.

ax.step(x, y, where='post')

and

ax.fill_between(x, y, step='post')

Maybe use step in both or pick a better kwarg name usable in both and not conflicting with where in fill_between which turns bin filling on/off

@andrzejnovak
Copy link
Contributor Author

Any input on renaming, while I'm working on #15065 ? Maybe sync step() to fill_between() and add the same where() kwarg for skipping segments?

@timhoffm
Copy link
Member

timhoffm commented Mar 25, 2020

This should also be consistent with

ax.plot(x, y, drawstyle='step-post')

Maybe we should

ax.fill_between(x, y, drawstyle='step-post')

But then again, is it worth the deprecation?

ax.step is just a thin wrapper around plot, setting the drawstyle. It must have a straight-forward parameter name. I'd leave where.

@github-actions
Copy link

This issue has been marked "inactive" because it has been 365 days since the last comment. If this issue is still present in recent Matplotlib releases, or the feature request is still wanted, please leave a comment and this label will be removed. If there are no updates in another 30 days, this issue will be automatically closed, but you are free to re-open or create a new issue if needed. We value issue reports, and this procedure is meant to help us resurface and prioritize issues that have not been addressed yet, not make them disappear. Thanks for your help!

@github-actions github-actions bot added the status: inactive Marked by the “Stale” Github Action label Jun 28, 2023
@timhoffm
Copy link
Member

Let‘s not go through the hassle of an API change. step() is a bit awkward anyway and we nowadays have stairs(), which is preferable in many cases.

@timhoffm timhoffm closed this as not planned Won't fix, can't repro, duplicate, stale Jun 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API: consistency status: inactive Marked by the “Stale” Github Action
Projects
None yet
Development

No branches or pull requests

3 participants