-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Inconsistent kwarg naming between step() and fill_between() #15085
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
Any input on renaming, while I'm working on #15065 ? Maybe sync |
This should also be consistent with
Maybe we should
But then again, is it worth the deprecation?
|
This issue has been marked "inactive" because it has been 365 days since the last comment. If this issue is still present in recent Matplotlib releases, or the feature request is still wanted, please leave a comment and this label will be removed. If there are no updates in another 30 days, this issue will be automatically closed, but you are free to re-open or create a new issue if needed. We value issue reports, and this procedure is meant to help us resurface and prioritize issues that have not been addressed yet, not make them disappear. Thanks for your help! |
Let‘s not go through the hassle of an API change. |
Calling step style is using a different kwarg name in
step()
and `fill_between() i.e.and
Maybe use
step
in both or pick a better kwarg name usable in both and not conflicting withwhere
in fill_between which turns bin filling on/offThe text was updated successfully, but these errors were encountered: