Thanks to visit codestin.com
Credit goes to github.com

Skip to content

MAINT: CircleCI build merged PRs #20658

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
larsoner opened this issue Jul 16, 2021 · 1 comment · Fixed by #20680
Closed

MAINT: CircleCI build merged PRs #20658

larsoner opened this issue Jul 16, 2021 · 1 comment · Fixed by #20680
Milestone

Comments

@larsoner
Copy link
Contributor

larsoner commented Jul 16, 2021

Describe the issue

CircleCI (unlike Travis, AppVeyor, Azure, GitHub Actions, etc.) by default just builds PR branches themselves, as opposed to those PRs merged with upstream/master. This forces people to rebase to deal with issues that crop up, for example in #20585 (comment), and also decreases uniformity across CIs.

Proposed fix

For a while (years?) in MNE now we have manually merged pull requests after the checkout step. I'm happy to port our code if people agree it would be useful. The only time it breaks or dies is when there are merge conflicts (i.e., the code can't be successfully merged), which arguably is fine behavior because people should merge/rebase at that point anyway.

EDIT: Also need these lines

@QuLogic
Copy link
Member

QuLogic commented Jul 16, 2021

Sure, feel free to PR it here. I've also been meaning to cop the better name for the CircleCI artifact check job that you have.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants