Thanks to visit codestin.com
Credit goes to github.com

Skip to content

DEV: Decide if pre-commit should continue to be used #22949

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
matthewfeickert opened this issue Apr 30, 2022 · 1 comment
Closed

DEV: Decide if pre-commit should continue to be used #22949

matthewfeickert opened this issue Apr 30, 2022 · 1 comment

Comments

@matthewfeickert
Copy link
Contributor

matthewfeickert commented Apr 30, 2022

OK, I have turned pre-commit on for the main repo (it was already on for pytest-mpl and ipympl). I am not super stoked that it has the ability to push to the main repo, but it is not the only application with similar access.

Originally posted by @tacaswell in #22777 (comment)

@tacaswell turned on pre-commit.ci for PR #22777

pre-commit.ci status

following discussions in PR #22809, PR #22777, and on Gitter.

There was not a clear consensus if the dev team was comfortable with another service that has push permissions like those shown in matthewfeickert#9 being connected to the matplotlib/matplotlib repo and if the examples shown in matthewfeickert#12 provided information that was acceptable.

Given #22777 (comment)

I'm in favor of getting this running on CI in any way that marks with a red-x, merging this, and then iterating on how best to notify at what needs to be changed.

pre-commit.ci was turned on, but the dev team should decide if they are happy with it or not. If they are happy with it, I am willing to help answer any questions they have in the future on it and make demo PRs on my forks of any situations they might be concerned with. If they are not happy, I am willing to help implement a solution that is acceptable to them.

@matthewfeickert matthewfeickert changed the title DEV: Decide if pre-commit should continue to be used on DEV: Decide if pre-commit should continue to be used May 1, 2022
@matthewfeickert
Copy link
Contributor Author

As the dev team hasn't complained yet about anything going wrong with precommit.ci after nearly a month and the status badge for main

pre-commit.ci status

is green, then I'm going to close this Issue. If there are any questions or concerns though please ping me and I will work with the dev team to get a solution that they are happy with. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant