Thanks to visit codestin.com
Credit goes to github.com

Skip to content

[Bug]: check_figures_equal decorator doesn't respect new figure properties set in test #24875

Closed
@chahak13

Description

@chahak13

Bug summary

We use the check_figures_equal in testing to compare figures. This decorator uses two figure instances fig_test and fig_ref for comparison. If we set any figure properties (like facecolor) in the test, they don't seem to be propagated when saving the actual figure.

Ran into this while writing a test for #24816 (cc @anntzer, for reference)

Code for reproduction

@check_figures_equal(extensions=["png"])
def test_test(fig_test, fig_ref):
    ax_test = fig_test.add_subplot()
    ax_test.set(xticks=[], yticks=[])
    fig_test.set_facecolor("teal")

    ax_ref = fig_ref.add_subplot()
    ax_ref.set(xticks=[], yticks=[])
    fig_ref.set_facecolor("none")

Actual outcome

This test passes, which suggests that the two figures created are equal but they actually aren't since the facecolor for both figures are set to be different.

Expected outcome

This test shouldn't pass and the figures should have facecolors "teal" and "none" respectively.

Additional information

No response

Operating system

Arch

Matplotlib Version

3.6.0.dev1889+gc59a7fa8db.d20230103

Matplotlib Backend

No response

Python version

3.10

Jupyter version

No response

Installation

None

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions