Thanks to visit codestin.com
Credit goes to github.com

Skip to content

CI: isort should check plot_types? #25303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
jklymak opened this issue Feb 23, 2023 · 1 comment · Fixed by #25304
Closed

CI: isort should check plot_types? #25303

jklymak opened this issue Feb 23, 2023 · 1 comment · Fixed by #25304
Labels
CI: testing CI configuration and testing
Milestone
v3.8.0

Comments

@jklymak
Copy link
Member

jklymak commented Feb 23, 2023

Summary

matplotlib/.pre-commit-config.yaml

Line 50 in 17db60b

files: ^tutorials/|^examples/
doesn't include plot_types. Not sure if that was on purpose or not. ping @dstansby, #25099

Proposed fix

No response
@jklymak jklymak added Maintenance CI: testing CI configuration and testing and removed Maintenance labels Feb 23, 2023
@dstansby
Copy link
Member

This was not on purpose, I wasn't aware of this folder so thanks for pinging me! I'll get a PR in to add it.

@dstansby dstansby mentioned this issue Feb 23, 2023
Merged
6 tasks
@QuLogic QuLogic added this to the v3.8.0 milestone Feb 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
CI: testing CI configuration and testing
Projects
None yet
Milestone
v3.8.0
Development

Successfully merging a pull request may close this issue.

Add import sorting to /plot_types dstansby/matplotlib
3 participants
@QuLogic @jklymak @dstansby