-
-
Notifications
You must be signed in to change notification settings - Fork 7.9k
Sphinx-Gallery 0.12 kills AppVeyor tests #25416
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
I don't think so? This is just breaking a test for us, so is just a maintenance issue that we can fix in master at any time. |
It might make sense to hard-pin sphinx-gallery on 3.7.x, but we should adapt our test on main. |
You are probably correct. I just think it is nicer that these things are noted before it breaks the actual tests... But I also realize that quite a lot of things can break and one would need to go all-out bleeding edge of all packages which may cause problems not related to mpl... |
It just that SG is all internal use - we don't ship it to anyone, so we don't need to be super careful about making sure any particular version works.
Yep that makes sense to me. |
I am confused why this is only hitting appveyor though? |
The test is skipped if Sphinx Gallery is not installed. I guess Appveyor is the only one using the Conda yml, and the others install with pip?
|
Uh oh!
There was an error while loading. Please reload this page.
Summary
Proposed fix
Seems like sphinx-gallery have changed their example header in 0.12.
Maybe it is worth adding downloading sphinx-gallery dev version to the nightlies as well?
The text was updated successfully, but these errors were encountered: